[14.0][MIG] mrp_production_request -> mrp_request: Migration to V14 #625
Conversation
|
I rename this module because of this comment in issue #534 from @LoisRForgeFlow
But also I think that is better to use mrp_production_request to avoid migration issues, I can change the name. What do you think @LoisRForgeFlow @bealdav ? |
|
@alan196 Ah, ok, it was done to try to avoid very long name. then 👍 from my side. |
|
@MiquelRForgeFlow can you advise on how to deal with this change of module and model name in openupgrade? |
alan196
force-pushed
the
14.0-mig-mrp_production_request
branch
from
ec434cf to
ddb78ce
Compare
|
@MiquelRForgeFlow @JordiBForgeFlow I created the migration scripts 👍 now it's ready to review! |
|
Thanks for this work: coverage improved, rename, etc. |
|
Here OCA/OpenUpgrade#2618 I have done the module rename :) |
alan196
force-pushed
the
14.0-mig-mrp_production_request
branch
from
ddb78ce to
72d9536
Compare
|
@MiquelRForgeFlow All requested changes are done 👍 Could you help me to review 🙏 |
| request = self.request_model.search( | ||
| [("product_id", "=", self.product_orderpoint.id)] | ||
| ) | ||
| self.assertEqual(len(request), 1) |
There was a problem hiding this comment.
travis is falling here
|
Travis is red |
|
Hello, Is this PR alive and is it on its way to being fixed? Thanks |
alan196
force-pushed
the
14.0-mig-mrp_production_request
branch
2 times, most recently
from
791700f to
03ed45d
Compare
|
I rebased the module and run the test locally and it works. The issue with the test is raised when this module is installed with mrp_multi_level The test validates if procurement is not generated twice if there is already an existing mrp.request How can we proceed? It can be a bug caused with mrp_multi_level module? 🤔 |
|
I'm following up on this, did you have the chance to look at it? |
|
Sorry, I didn't have free time to check this. I hope some else can help eventually :) |
|
Hi @alan196! We at Coopdevs are willing to help in this migration. We've also run the module in local and its working almost fine (I only miss the label in the Manufacturing Request's checkbox at Inventory) We've seen that the v13 maintainer for both this and mrp_multi_level modules is @LoisRForgeFlow, maybe he could do a code review? Thank you all! Best regards. |
alan196
force-pushed
the
14.0-mig-mrp_production_request
branch
from
03ed45d to
1a510fe
Compare
|
Hello @oyale I have fixed the checkbox in the product template view. I also rebased the code. Could you help me to review 🙏. |
alan196
force-pushed
the
14.0-mig-mrp_production_request
branch
from
1a510fe to
1a54ec9
Compare
|
Unfortunately tests are failing: |
Currently translated at 97.0% (96 of 99 strings) Translation: manufacture-11.0/manufacture-11.0-mrp_production_request Translate-URL: https://translation.odoo-community.org/projects/manufacture-11-0/manufacture-11-0-mrp_production_request/de/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 99.0% (98 of 99 strings) Translation: manufacture-11.0/manufacture-11.0-mrp_production_request Translate-URL: https://translation.odoo-community.org/projects/manufacture-11-0/manufacture-11-0-mrp_production_request/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-mrp_production_request Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_production_request/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-13.0/manufacture-13.0-mrp_production_request Translate-URL: https://translation.odoo-community.org/projects/manufacture-13-0/manufacture-13-0-mrp_production_request/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-13.0/manufacture-13.0-mrp_production_request Translate-URL: https://translation.odoo-community.org/projects/manufacture-13-0/manufacture-13-0-mrp_production_request/
alan196
force-pushed
the
14.0-mig-mrp_production_request
branch
from
c8359db to
1991e35
Compare
|
@elvise I have rebased, the issue related to another module is still affecting tests. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Proposed changes
Migration PR for module mrp_production_request
Types of changes
Checklist
Further comments
The module was renamed to mrp_request.
I have changed the dependency from stock_available_unreserved to stock_free_qty as commented.